alextab93/buildx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

dap: fix the run mount input names

Browse Source 
The mounts for exec operations was misconstruing most input names as the
root mount because it was using the wrong input index to match with the
exec mounts.

The correct input index is now being used so bind mounts and other types
of mounts should now show the correct mount destination rather than only
showing the root mount.

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
This commit is contained in:
Jonathan A. Sternberg
2026-01-06 12:29:51 -06:00
parent 5546d171a0
commit 19eadba5fc
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dap/thread.go
+3 -3
View File
@@ -532,7 +532,7 @@ func (t *thread) solveInputs(ctx context.Context, target *step) (string, map[str
var root string var root string
refs := make(map[string]gateway.Reference) refs := make(map[string]gateway.Reference)
for i, input := range op.Inputs { for i, input := range op.Inputs {
k := t.determineInputName(op, input) k := t.determineInputName(op, i, input)
if _, ok := refs[k]; ok || k == "" { if _, ok := refs[k]; ok || k == "" {
continue continue
} }
@@ -550,11 +550,11 @@ func (t *thread) solveInputs(ctx context.Context, target *step) (string, map[str
return root, refs, nil return root, refs, nil
} }
func (t *thread) determineInputName(op *pb.Op, input *pb.Input) string { func (t *thread) determineInputName(op *pb.Op, index int, input *pb.Input) string {
switch op := op.Op.(type) { switch op := op.Op.(type) {
case *pb.Op_Exec: case *pb.Op_Exec:
for _, m := range op.Exec.Mounts { for _, m := range op.Exec.Mounts {
if m.Input >= 0 && m.Input == input.Index { if m.Input >= 0 && m.Input == int64(index) {
return m.Dest return m.Dest
} }
} }