alextab93/buildx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity
3,102 Commits 1 Branch 1 Tag
f5196f116773ddfa1f0a461320a87702201d8a22
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tonis TiigiandCrazyMax ef99381eab otel: avoid tracing raw os arguments 
User might pass a value that they don't expect to
be kept in trace storage. For example some cache backends
allow passing authentication tokens with a flag.

Instead use known primary config values as attributes
of the root span.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-03-17 18:14:52 +01:00
Tõnis TiigiandGitHub 97f1d47464 Merge pull request #3063 from crazy-max/driver-ctn-gpu-request 
driver: request gpu when creating container builder
 2025-03-13 09:56:10 -07:00
Tõnis TiigiandGitHub 0d708c0bc2 Merge pull request #3058 from crazy-max/buildkit-0.20.1 
vendor: github.com/moby/buildkit v0.20.1
 2025-03-11 09:30:42 -07:00
Tõnis TiigiandGitHub 3a7523a117 Merge pull request #3057 from crazy-max/update-compose 
vendor: update compose-go to v2.4.8
 2025-03-11 09:09:46 -07:00
Tõnis TiigiandGitHub b88423be50 Merge pull request #3053 from tonistiigi/modernize-fixes 
lint: apply x/tools/modernize fixes and validation
 2025-03-10 18:37:51 -07:00
Tonis Tiigi c1e2ae5636 history: generalize query loading 
Some commands (logs/open) were still missing offset handling.
Now all commands use the same reference parsing/sort.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-03-10 15:51:03 -07:00
Tõnis TiigiandGitHub 23afb70e40 Merge pull request #3039 from tonistiigi/history-import 
history: add history import command
 2025-03-10 10:09:36 -07:00
Tonis Tiigi d5d3d3d502 lint: apply x/tools/modernize fixes 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-03-07 16:37:24 -08:00
Tõnis TiigiandGitHub e19c729d3e Merge pull request #3049 from tonistiigi/history-inspect-index 
history: allow index based inspect of builds
 2025-03-06 11:09:36 -08:00
Tonis Tiigi 058c098c8c history: allow index based inspect of builds 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-03-05 21:33:24 -08:00
Tõnis TiigiandGitHub 7b7dbe88b1 Merge pull request #3046 from crazy-max/buildkit-0.20.1 
dockerfile: update buildkit to 0.20.1
 2025-03-05 17:20:14 -08:00
Tonis Tiigi cadf4a5893 history: add multi-file/stdin import 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-03-05 11:12:52 -08:00
Tonis Tiigi 963b9ca30d history: print urls after importing builds 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-03-04 16:13:49 -08:00
Tõnis TiigiandGitHub e23695d50d Merge pull request #3042 from crazy-max/ci-bump-ubuntu 
ci: bump to ubuntu-24.04
 2025-03-04 15:41:06 -08:00
Tõnis TiigiandGitHub 9a204c44c3 Merge pull request #3031 from crazy-max/bake-set-append 
bake: support += operator to append with overrides
 2025-03-04 09:33:57 -08:00
Tonis Tiigi fea7459880 history: add history import command 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-03-03 22:52:05 -08:00
Tõnis TiigiandGitHub e2d52a8465 Merge pull request #2901 from crazy-max/netbsd 
build and test netbsd
 2025-03-03 16:43:02 -08:00
Tõnis TiigiandGitHub 48a591b1e1 Merge pull request #3032 from crazy-max/bake-secrets-dupes 
correctly remove duplicated secrets and ssh keys
 2025-03-03 16:40:14 -08:00
Tonis Tiigi 4f7d145c0e avoid double pushing with docker driver with containerd 
In this mode buildkit can push directly so pushing manually
with docker would result in pushing image twice.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-24 16:48:57 -08:00
Tonis Tiigi ccdf63c644 imagetools: avoid multiple tag pushes on create 
Ensure only the final manifest is pushed by tag and intermediate
blobs are only pushed by digest to avoid tag temorarily pointing to
wrong image.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-24 16:48:15 -08:00
Tonis Tiigi 6272ae1afa remove accidental debug 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-20 15:41:13 -08:00
Tonis Tiigi 79a978484d progress: fix race on pausing progress on debug shell 
Current progress writer has a logic of pausing/unpausing
the printer and internally recreating internal channels.

This conflicts with a change that added sync.Once to Wait
to allow it being called multiple times without erroring.

In debug shell this could mean that new progress printer
showed up in debug shell because it was not closed.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-17 21:02:49 -08:00
Tõnis TiigiandCrazyMax 0c296fe857 support for device entitlement in build and bake 
Allow access to CDI Devices in Buildkit v0.20.0+ for
devices that are not automatically allowed to be used by
everyone in BuildKit configuration.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
 2025-02-14 11:51:47 +01:00
Tõnis TiigiandGitHub ef73c64d2c Merge pull request #2993 from tonistiigi/update-buildkit-v0.20.0-rc2 
vendor: update buildkit to v0.20.0-rc2
 2025-02-13 17:15:50 -08:00
Tonis Tiigi 1784f84561 vendor: update buildkit to v0.20.0-rc2 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-13 16:54:50 -08:00
Tõnis TiigiandGitHub 6a6fa4f422 Merge pull request #2986 from tonistiigi/remove-x-slices 
remove import of x/exp
 2025-02-13 10:16:48 -08:00
Tõnis TiigiandGitHub 2389d457a4 Merge pull request #2988 from crazy-max/ctn-driver-display-pull-error 
docker-container: check error from response body when pulling image
 2025-02-12 08:47:05 -08:00
Tonis Tiigi 79e3f12305 remove import of x/exp 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 19:23:36 -08:00
Tõnis TiigiandGitHub 1dc5f0751b Merge pull request #2983 from tonistiigi/update-buildkit-v0.20.0-rc1 
vendor: update buildkit to v0.20.0-rc1
 2025-02-11 16:20:02 -08:00
Tonis Tiigi 7ba4da0800 gha: send v2 url as url_v2 
Some repositories already have v2 enabled and that
causes errors avainst older BuildKit. To avoid that we
need to send both URLs as separate keys.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 15:49:29 -08:00
Tonis Tiigi a64e628774 .github: test github runtime envs 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 15:41:15 -08:00
Tonis Tiigi 1c4b1a376c show CDI devices in builder inspection 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 14:52:33 -08:00
Tonis Tiigi e1f690abfc allow passing github cache v2 urls from env 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 14:52:33 -08:00
Tonis Tiigi 03569c2188 vendor: update buildkit to v0.20.0-rc1 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 14:52:19 -08:00
Tõnis TiigiandGitHub 350d3f0f4b Merge pull request #2904 from tonistiigi/history-command-trace 
Add history trace command
 2025-02-11 12:40:10 -08:00
Tonis Tiigi 1089ff7341 history: add comparison support to trace 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 11:40:04 -08:00
Tonis Tiigi 7433d37183 history: add loadTrace function and support for loading Nth trace 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 11:40:04 -08:00
Tonis Tiigi f9a76355b5 history: add UI view to traces 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 11:40:01 -08:00
Tonis Tiigi cfeea34b2d add history trace command 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-11 11:38:23 -08:00
Tõnis TiigiandGitHub ba2d3692a6 Merge pull request #2982 from crazy-max/revert-docker-28-vendor 
Revert "vendor: docker, docker/cli v28.0.0-rc.1"
 2025-02-11 11:37:32 -08:00
Tõnis TiigiandGitHub 853b593a4d Merge pull request #2981 from crazy-max/hack-mount-docker-cfg 
hack: mount docker config on gha
 2025-02-11 10:36:45 -08:00
Tonis Tiigi f11496448a vendor: update buildkit to 0e3037c0182e 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-10 16:48:59 -08:00
Tõnis TiigiandGitHub c8c9c72ca6 Merge pull request #2964 from crazy-max/history-inspect-json 
history: inspect json and go template format
 2025-02-10 16:30:42 -08:00
Tõnis TiigiandGitHub 9fe8139022 Merge pull request #2976 from crazy-max/ci-fix-vagrant 
ci: install latest vagrant
 2025-02-10 16:16:15 -08:00
Tõnis TiigiandGitHub b8e9c28315 Merge pull request #2970 from crazy-max/fix-ls-json 
ls: fix duplicated builders for json format
 2025-02-10 09:28:17 -08:00
Tõnis TiigiandGitHub d557da1935 Merge pull request #2957 from ndeloof/prompt-rawjson 
don't warn user about missing --allows when running with progress=rawjson
 2025-02-07 16:34:10 -08:00
Tõnis TiigiandGitHub 4b90b84995 Merge pull request #2965 from jsternberg/handle-unknown-values 
buildflags: handle unknown values from cty
 2025-02-06 10:06:49 -08:00
Tonis TiigiandCrazyMax 9d640f0e33 history: add formatting support to inspect 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-02-06 10:45:27 +01:00
Tõnis TiigiandGitHub 934841f329 Merge pull request #2958 from crazy-max/fix-debug-invoke 
debug: fix invoke on error
 2025-01-31 10:17:08 -08:00
Tõnis TiigiandGitHub a11507344a Merge pull request #2932 from crazy-max/buildkit-0.19.0 
vendor: update buildkit to v0.19.0
 2025-01-22 12:57:37 -08:00
Tõnis TiigiandGitHub 17af006857 Merge pull request #2944 from jsternberg/cache-ref-only-format-fix 
buildflags: fix ref only format for command line and bake
 2025-01-22 12:57:02 -08:00
Tõnis TiigiandGitHub cc4a291f6a Merge pull request #2941 from crazy-max/ci-fix-docs-upstream 
ci: use main branch for docs upstream validation workflow
 2025-01-22 10:36:56 -08:00
Tõnis TiigiandGitHub b2bbb337e4 Merge pull request #2835 from dvdksn/bake-v019-entitlements 
docs: bake v0.19 entitlements
 2025-01-22 09:48:38 -08:00
Tõnis TiigiandGitHub c1d3955fbe Merge pull request #2928 from tonistiigi/update-buildkit-v0.19.0-rc3 
vendor: update buildkit to v0.19.0-rc3
 2025-01-17 12:53:50 -08:00
Tonis Tiigi d0b63e60e2 vendor: update buildkit to v0.19.0-rc3 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-17 12:09:08 -08:00
Tõnis TiigiandGitHub e141c8fa71 Merge pull request #2923 from crazy-max/docs-bake-overrides 
chore: comments to not forget to update docs
 2025-01-17 10:45:44 -08:00
Tõnis TiigiandGitHub 2ee156236b Merge pull request #2925 from tonistiigi/history-inspect-error 
history: add error details to history inspect command
 2025-01-17 10:23:59 -08:00
Tonis Tiigi 1335264c9d history: update formatting of error logs 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-17 08:54:38 -08:00
Tonis Tiigi 8c27b5c545 history: make sure started time is shown in current timezone 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-16 21:12:37 -08:00
Tonis Tiigi f7594d484b history: fix printing desktop URL 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-16 21:12:37 -08:00
Tonis Tiigi f118749cdc history: add error details to history inspect command 
For failed builds, show the source with error location and last
logs for vertex that caused the error. When debug mode is on,
stacktrace is printed.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-16 21:12:17 -08:00
Tõnis TiigiandGitHub a18ff4d5ef Merge pull request #2891 from tonistiigi/history-command-initial 
Add buildx history command
 2025-01-15 08:51:23 -08:00
Tonis TiigiandCrazyMax 6220e0aae8 add history inspect attachment command 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-15 16:17:21 +01:00
Tonis TiigiandCrazyMax d9abc78e8f update history inspect formatting 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-15 16:17:21 +01:00
Tonis TiigiandCrazyMax 3313026961 add buildx history inspect formatting 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-15 16:17:20 +01:00
Tonis TiigiandCrazyMax 06912aa24c Add buildx history command 
These commands allow working with build records
of completed and running builds.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-15 16:17:20 +01:00
Tonis Tiigi 44fa243d58 vendor: update buildkit to v0.19.0-rc1 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-14 14:24:38 -08:00
Tõnis TiigiandGitHub 630066bfc5 Merge pull request #2905 from crazy-max/bake-infer-auth-token 
bake: infer git auth token from remote files to build request
 2025-01-14 09:12:53 -08:00
Tõnis TiigiandGitHub 026ac2313c Merge pull request #2910 from crazy-max/update-testify 
vendor: github.com/stretchr/testify v1.10.0
 2025-01-14 08:10:55 -08:00
Tõnis TiigiandGitHub 1eb167a767 Merge pull request #2908 from crazy-max/update-pty 
vendor: github.com/creack/pty v1.1.24
 2025-01-13 23:27:23 -08:00
Tõnis TiigiandGitHub 45d2ec69f1 Merge pull request #2911 from crazy-max/update-hcl 
vendor: update hcl dependencies
 2025-01-13 10:30:04 -08:00
Tõnis TiigiandGitHub 793ec7f3b2 Merge pull request #2866 from crazy-max/ci-e2e-bake 
ci: e2e bake
 2025-01-13 10:22:30 -08:00
Tõnis TiigiandGitHub ada44e82ea Merge pull request #2900 from crazy-max/bake-list-flag 
bake: replace --list-targets and --list-variables flags with --list flag
 2025-01-10 07:59:28 -08:00
Tõnis TiigiandGitHub 16edf5d4aa Merge pull request #2898 from tonistiigi/bake-entitlement-ssh-fix 
bake: fix entitlements check for default SSH socket
 2025-01-09 08:49:23 -08:00
Tonis Tiigi 5f057bdee7 bake: fix entitlements check for default SSH socket 
There was a mixup between fs.read and ssh entitlements check.

Corrected behavior is that if bake definition requires default
SSH forwarding then "ssh" entitlement is needed. If it requires
SSH forwarding via fixed file path then "fs.read" entitlement is
needed for that path.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2025-01-08 18:19:18 -08:00
Tõnis TiigiandGitHub 883806524a Merge pull request #2894 from crazy-max/ci-update-bake-action 
ci: update bake-action to v6
 2025-01-08 09:32:40 -08:00
Tõnis TiigiandGitHub 38b71998f5 Merge pull request #2864 from crazy-max/builder-validate-config 
builder: validate buildkit configuration
 2025-01-08 09:17:08 -08:00
Tõnis TiigiandGitHub 7cf12fce98 Merge pull request #2875 from tonistiigi/bake-fs-entitlements-error 
bake: make FS entitlements error by default
 2025-01-07 16:13:42 -08:00
Tõnis TiigiandGitHub 07190d20da Merge pull request #2892 from crazy-max/undock-0.9.0 
dockerfile: update undock to 0.9.0
 2025-01-07 16:13:28 -08:00
Tõnis TiigiandGitHub 0fc204915a Merge pull request #2804 from crazy-max/tests-bsd 
test bsd
 2025-01-06 09:34:46 -08:00
Tõnis TiigiandGitHub 3a0eeeacd5 Merge pull request #2863 from crazy-max/bake-fix-missing-default 
bake: fix missing default target in group's default targets
 2025-01-06 09:09:35 -08:00
Tõnis TiigiandGitHub 206bd6c3a2 Merge pull request #2876 from tonistiigi/progress-load-fix 
progress: fix missing last progress from loading layers
 2025-01-02 10:38:17 -08:00
Tonis Tiigi 875e717361 progress: fix missing last progress from loading layers 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-12-19 21:46:00 -08:00
Tonis Tiigi 72c3d4a237 bake: make FS entitlements error by default 
Change FS entitlements checks from warning to error
by default as expressed in initial PR. Users can still
opt-out with environment variable if the choose to.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-12-19 17:14:35 -08:00
Tõnis TiigiandGitHub 5c5bc510ac Merge pull request #2848 from jsternberg/bake-composable-attributes-attests 
bake: implement composable attributes for attestations
 2024-12-18 13:11:50 -08:00
Tõnis TiigiandGitHub 0dfc4a1019 Merge pull request #2871 from jsternberg/bake-empty-variable-tests 
bake: test empty override
 2024-12-18 11:00:49 -08:00
Tõnis TiigiandGitHub 3771fe2034 Merge pull request #2814 from jsternberg/bake-composable-attributes-phase2 
bake: various fixes for composable attributes
 2024-12-18 09:35:35 -08:00
Tonis Tiigi a53ed0a354 add additional test coverage for FS entitlement paths 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-12-16 22:29:35 -08:00
Tonis Tiigi 737da6959d bake: change evaluation of entitlement paths 
Currently, to compare the local path used by bake against the paths allowed
by entitlements, symlinks were evaluated for path normalization so that the
local path used by build was allowed to not exist while the path allowed by
entitlement needed to exist. If the path used by the build did not exist,
then the deepest existing parent path was used instead. This was concistent
with entitlement rules as that parent path would be the actual path access
is needed.

This raised an issue with `--set` if one provides a non-existing path as
an argument, as these paths are supposed to be allowed automatically. With
the above restrictions set to allowed paths, this meant the build would fail
as it can't grant entitlement to the non-existing paths.

This changes the evaluation logic for allowing paths so that they do not
need to exist. If such a case appears, then the path is evaluated to the
last component that exists, and then the rest of the path is appended as is.

This means that for example, if `output = /tmp/out/foo/` is set in HCL
and `/tmp` is the last component that exists then invoking build with
`--allow fs.write=/tmp/out/foo` will not fail with stat error anymore
but will fail in entitlements validation as build would also need to
write `/tmp/out` that is not inside the allowed `/tmp/out/foo` path. The
same would apply to `--set` as well so that if it points to
a non-existing path, then an additional `--allow` rule is needed
providing access to writing to the last existing component of that path.
This may or may not be unexpected.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-12-16 22:29:24 -08:00
Tonis Tiigi 6befa70cc8 update test BuildKit to v0.18.2 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-12-16 15:47:45 -08:00
Tõnis TiigiandGitHub 3e3242cfdd Merge pull request #2851 from crazy-max/dockerfile-pin-alpine 
dockerfiles: pin alpine version
 2024-12-10 10:47:04 -08:00
Tonis Tiigi fdac6d5fe7 update xx to v1.6.1 
Fixes compatibility issues with Alpine 3.21

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-12-09 18:48:50 -08:00
Tõnis TiigiandGitHub d4eca07af8 Merge pull request #2834 from tonistiigi/bake-entitlements-output-fix 
bake: fix entitlements path checks for local outputs
 2024-12-06 13:52:48 -08:00
Tonis Tiigi 6810a7c69c update buildkit used for tests 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-12-03 17:59:08 -08:00
Tonis Tiigi dd596d6542 bake: allow entitlements from overrides automatically 
If override specifies a path, mark it automatically allowed
so there is no need to use duplicate flags for defining the
same feature.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-12-02 17:16:28 -08:00
Tonis Tiigi c6e403ad7f bake: fix entitlements path checks for local outputs 
Previous check based on dest attributes was not correct
as the attributes already get converted before validation happens.

Because the local path is not preserved for single-file
outputs and gets replaced by io.Writer, a temporary array variable
was needed. This value should instead be added to ExportEntry
struct in BuildKit in future revision.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-12-02 15:00:29 -08:00
Tõnis TiigiandGitHub 71c7889719 Merge pull request #2821 from tonistiigi/update-buildkit-v0.18.0 
vendor: update buildkit to v0.18.0
 2024-11-26 14:49:31 -08:00
Tonis Tiigi a3418e0178 vendor: update buildkit to v0.18.0 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-11-26 13:57:25 -08:00
Tõnis TiigiandGitHub 6a1cf78879 Merge pull request #2818 from tonistiigi/vendor-buildkit-v0.18.0-rc2 
vendor: update buildkit to v0.18.0-rc2
 2024-11-25 17:52:46 -08:00
Tonis Tiigi ec1f712328 vendor: update buildkit to v0.18.0-rc2 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2024-11-25 17:42:30 -08:00